Deprecate sky_diffuse_passias and amend plot_passias_diffuse_shading.py gallery example#2589
Open
kdebrab wants to merge 1 commit intopvlib:mainfrom
Open
Conversation
kdebrab
force-pushed
the
amend-sky_diffuse_passias-and-plot_passias_diffuse_shading
branch
3 times, most recently
from
687d265 to
e18859e
Compare
kdebrab
changed the title
sky_diffuse_passias and amend plot_passias_diffuse_shading.py gallery example
kdebrab
force-pushed
the
amend-sky_diffuse_passias-and-plot_passias_diffuse_shading
branch
2 times, most recently
from
0d9e122 to
f0bc077
Compare
kdebrab
force-pushed
the
amend-sky_diffuse_passias-and-plot_passias_diffuse_shading
branch
from
f0bc077 to
acac666
Compare
RDaxini
reviewed
Dec 4, 2025
| # As ``k`` decreases, GCR increases, so self-shading loss increases and | ||
| # collected diffuse irradiance decreases. | ||
| # | ||
| # However, the pvlib-python authors believe that this approach is incorrect. |
Member
There was a problem hiding this comment.
What's the source of this and the other comments below? Was this discussed in an issue somewhere?
| # :py:func:`pvlib.shading.masking_angle_passias` and | ||
| # :py:func:`pvlib.shading.sky_diffuse_passias`. | ||
| # | ||
| # However, the pvlib-python authors believe that this approach is incorrect. |
Member
There was a problem hiding this comment.
Same comment here as my other comment https://github.com/pvlib/pvlib-python/pull/2589/files#r2590549604
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests addedUpdates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.